diff options
| author |   Eric Blake <eblake@redhat.com> | 2011-06-29 12:04:08 -0600 |
|---|---|---|
| committer | Eric Blake <eblake@redhat.com> | 2011-06-30 11:36:51 -0600 |
| commit | cdb0e0dc3fd2c217e6391ec134334b3dfe4410cc (patch) | |
| tree | 0a5d68612704ad49de8506d450afdb68a0111c3f | |
| parent | virsh: avoid integer overflow (diff) | |
| download | libvirt-cdb0e0dc3fd2c217e6391ec134334b3dfe4410cc.tar.gz libvirt-cdb0e0dc3fd2c217e6391ec134334b3dfe4410cc.tar.bz2 libvirt-cdb0e0dc3fd2c217e6391ec134334b3dfe4410cc.zip | |
virsh: avoid uninitialized variable
Detected by Coverity; neither vshCmddefHelp nor vshCmdOptParse
was initializing opts_required.
* tools/virsh.c (vshCmddefOptParse): Always initialize bitmaps.
| -rw-r--r-- | tools/virsh.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/tools/virsh.c b/tools/virsh.c index f96ee040d..9a189fddb 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -11915,12 +11915,15 @@ vshCmddefGetInfo(const vshCmdDef * cmd, const char *name) } static int -vshCmddefOptParse(const vshCmdDef *cmd, uint32_t* opts_need_arg, +vshCmddefOptParse(const vshCmdDef *cmd, uint32_t *opts_need_arg, uint32_t *opts_required) { int i; bool optional = false; + *opts_need_arg = 0; + *opts_required = 0; + if (!cmd->opts) return 0; |