diff options
| author |   Tom Tromey <tom@tromey.com> | 2018-04-26 22:46:54 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-04-27 12:53:14 -0600 |
| commit | 632e107b32c0fe8aede62e070b00756e9fdd2c01 (patch) | |
| tree | 33106f00d62048ea028bdad94f0df1c21a463f3b /gdb/arm-tdep.c | |
| parent | MIPS/LD/testsuite: Update `run_dump_test' cases for non-DSO targets (diff) | |
| download | binutils-gdb-632e107b32c0fe8aede62e070b00756e9fdd2c01.tar.gz binutils-gdb-632e107b32c0fe8aede62e070b00756e9fdd2c01.tar.bz2 binutils-gdb-632e107b32c0fe8aede62e070b00756e9fdd2c01.zip | |
Enable -Wsuggest-override
I noticed the existence of -Wsuggest-override and so this patch
enables it for gdb. It found a few spots that could use "override".
Also I went ahead and removed all uses of the "OVERRIDE" macro.
Using override is beneficial because it makes it harder to change a
base class and then forget to change a derived class.
Tested by the buildbot.
ChangeLog
2018-04-27 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
* warning.m4 (AM_GDB_WARNINGS): Add -Wsuggest-override.
* dwarf2loc.c (class dwarf_evaluate_loc_desc): Use "override", not
"OVERRIDE".
(class symbol_needs_eval_context): Likewise.
* dwarf2read.c (mock_mapped_index::symbol_name_count)
(mock_mapped_index::symbol_name_at): Use "override". Remove
"virtual".
* dwarf2-frame.c (dwarf_expr_executor::get_addr_index): Use
"override".
(class dwarf_expr_executor): Use "override", not "OVERRIDE".
* aarch64-tdep.c (instruction_reader::read): Use "override".
(instruction_reader_test::read): Likewise.
* arm-tdep.c (instruction_reader::read): Use "override".
(instruction_reader_thumb::read): Likewise.
gdbserver/ChangeLog
2018-04-27 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
Diffstat (limited to 'gdb/arm-tdep.c')
| -rw-r--r-- | gdb/arm-tdep.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c index f64df4c5741..463fcaf94ba 100644 --- a/gdb/arm-tdep.c +++ b/gdb/arm-tdep.c @@ -13061,7 +13061,7 @@ public: class instruction_reader : public abstract_memory_reader { public: - bool read (CORE_ADDR memaddr, gdb_byte *buf, const size_t len) + bool read (CORE_ADDR memaddr, gdb_byte *buf, const size_t len) override { if (target_read_memory (memaddr, buf, len)) return false; @@ -13214,7 +13214,7 @@ public: : m_endian (endian), m_insns (insns), m_insns_size (SIZE) {} - bool read (CORE_ADDR memaddr, gdb_byte *buf, const size_t len) + bool read (CORE_ADDR memaddr, gdb_byte *buf, const size_t len) override { SELF_CHECK (len == 4 || len == 2); SELF_CHECK (memaddr % 2 == 0); |