diff options
author | 2009-10-30 01:01:22 +0000 | |
---|---|---|
committer | 2009-10-30 01:01:22 +0000 | |
commit | 145f177dace8458cfb725e4405da1c77f86786cf (patch) | |
tree | 62fbe01212f78d88cfad4044ca9c18005e661dc9 /editproducts.cgi | |
parent | Bug 524234: When there are no search results, include helpful links (diff) | |
download | bugzilla-145f177dace8458cfb725e4405da1c77f86786cf.tar.gz bugzilla-145f177dace8458cfb725e4405da1c77f86786cf.tar.bz2 bugzilla-145f177dace8458cfb725e4405da1c77f86786cf.zip |
Bug 525252: editproducts.cgi should only list classifications in which there are products you can administer - Patch by Frédéric Buclin <LpSolit@gmail.com> r=ghendricks a=LpSolit
Diffstat (limited to 'editproducts.cgi')
-rwxr-xr-x | editproducts.cgi | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/editproducts.cgi b/editproducts.cgi index eaef243fd..e1356abbc 100755 --- a/editproducts.cgi +++ b/editproducts.cgi @@ -80,8 +80,18 @@ if (Bugzilla->params->{'useclassification'} && !$classification_name && !$product_name) { - $vars->{'classifications'} = $user->in_group('editcomponents') ? - [Bugzilla::Classification->get_all] : $user->get_selectable_classifications; + my $class; + if ($user->in_group('editcomponents')) { + $class = [Bugzilla::Classification->get_all]; + } + else { + # Only keep classifications containing at least one product + # which you can administer. + my $products = $user->get_products_by_permission('editcomponents'); + my %class_ids = map { $_->classification_id => 1 } @$products; + $class = Bugzilla::Classification->new_from_list([keys %class_ids]); + } + $vars->{'classifications'} = $class; $template->process("admin/products/list-classifications.html.tmpl", $vars) || ThrowTemplateError($template->error()); |