aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbugreport%peshkin.net <>2004-07-27 22:13:48 +0000
committerbugreport%peshkin.net <>2004-07-27 22:13:48 +0000
commitfba06c0a5f82ddf2f73ef068752d697666464dc1 (patch)
tree1e3e2655bdc0553fac9fe7e9ee4b607873f69f3f /editversions.cgi
parentBug 251837: Add UI to add/remove 'My Bugs' link in footer (diff)
downloadbugzilla-fba06c0a5f82ddf2f73ef068752d697666464dc1.tar.gz
bugzilla-fba06c0a5f82ddf2f73ef068752d697666464dc1.tar.bz2
bugzilla-fba06c0a5f82ddf2f73ef068752d697666464dc1.zip
Bug 252450: Unlock tables in edit*.cgi before sending trailer
r=kiko a=justdave
Diffstat (limited to 'editversions.cgi')
-rwxr-xr-xeditversions.cgi5
1 files changed, 1 insertions, 4 deletions
diff --git a/editversions.cgi b/editversions.cgi
index a3a2e2cc5..c426891ed 100755
--- a/editversions.cgi
+++ b/editversions.cgi
@@ -124,6 +124,7 @@ sub EmitFormElements ($$)
sub PutTrailer (@)
{
my (@links) = ("Back to the <A HREF=\"query.cgi\">query page</A>", @_);
+ SendSQL("UNLOCK TABLES");
my $count = $#links;
my $num = 0;
@@ -444,7 +445,6 @@ if ($action eq 'delete') {
WHERE product_id = $product_id
AND value=" . SqlQuote($version));
print "Version deleted.<P>\n";
- SendSQL("UNLOCK TABLES");
unlink "$datadir/versioncache";
PutTrailer($localtrailer);
@@ -509,13 +509,11 @@ if ($action eq 'update') {
unless ($version) {
print "Sorry, I can't delete the version text.";
PutTrailer($localtrailer);
- SendSQL("UNLOCK TABLES");
exit;
}
if (TestVersion($product,$version)) {
print "Sorry, version '$version' is already in use.";
PutTrailer($localtrailer);
- SendSQL("UNLOCK TABLES");
exit;
}
SendSQL("UPDATE bugs
@@ -530,7 +528,6 @@ if ($action eq 'update') {
unlink "$datadir/versioncache";
print "Updated version.<BR>\n";
}
- SendSQL("UNLOCK TABLES");
PutTrailer($localtrailer);
exit;