diff options
author | 2010-07-08 14:51:28 -0700 | |
---|---|---|
committer | 2010-07-08 14:51:28 -0700 | |
commit | 124c46d598baca86873cf6cccab7ec64b5a599d5 (patch) | |
tree | fd13b920fdf750a0504772becf9f854af822b6be /page.cgi | |
parent | Bug 305412: Update the minimum Pg requirement to 8.3, to allow casting (diff) | |
download | bugzilla-124c46d598baca86873cf6cccab7ec64b5a599d5.tar.gz bugzilla-124c46d598baca86873cf6cccab7ec64b5a599d5.tar.bz2 bugzilla-124c46d598baca86873cf6cccab7ec64b5a599d5.zip |
Bug 567981 - Restore ability for page.cgi pages to contain . characters, but don't permit '..' at all.
[r=mkanat a=mkanat]
Diffstat (limited to 'page.cgi')
-rwxr-xr-x | page.cgi | 10 |
1 files changed, 7 insertions, 3 deletions
@@ -66,9 +66,13 @@ my $template = Bugzilla->template; my $id = $cgi->param('id'); if ($id) { - # Split into name and ctype, but be careful not to allow directory - # traversal. - $id =~ /^([\w\-\/]+)\.(\w+)$/; + # Be careful not to allow directory traversal. + if ($id =~ /\.\./) { + # two dots in a row is bad + ThrowCodeError("bad_page_cgi_id", { "page_id" => $id }); + } + # Split into name and ctype. + $id =~ /^([\w\-\/\.]+)\.(\w+)$/; if (!$2) { # if this regexp fails to match completely, something bad came in ThrowCodeError("bad_page_cgi_id", { "page_id" => $id }); |