aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVikraman Choudhury <vikraman.choudhury@gmail.com>2011-05-12 16:17:56 +0530
committerVikraman Choudhury <vikraman.choudhury@gmail.com>2011-05-12 16:17:56 +0530
commit144bfa8b04c4fc750fac206357d88c722a63653d (patch)
treed881ee7bbf361d15ede5e7aca31a11a26f4ff010
parenthandle favicon with a 404 error (diff)
downloadgentoostats-144bfa8b04c4fc750fac206357d88c722a63653d.tar.gz
gentoostats-144bfa8b04c4fc750fac206357d88c722a63653d.tar.bz2
gentoostats-144bfa8b04c4fc750fac206357d88c722a63653d.zip
fixes after code review
-rw-r--r--TODO8
-rwxr-xr-xserver/main.py4
-rw-r--r--server/post.py1
3 files changed, 8 insertions, 5 deletions
diff --git a/TODO b/TODO
index 3bbc2ce..0821f7b 100644
--- a/TODO
+++ b/TODO
@@ -1,3 +1,5 @@
-TODO: Return public uuid and md5sum of password
-TODO: Handle exceptions
-TODO: Remove gentoolkit dependency
+./server/post.py: #TODO: Improve this
+./server/post.py: #TODO: Handle exceptions
+./client/bin/client: #TODO: Return public uuid and md5sum of password
+./client/bin/client: #TODO: Handle exceptions
+./client/useflags.py:#TODO: Remove gentoolkit dependency
diff --git a/server/main.py b/server/main.py
index dbfd3ad..7796aba 100755
--- a/server/main.py
+++ b/server/main.py
@@ -27,8 +27,8 @@ class stats:
def GET(self, uuid):
if uuid == 'favicon.ico':
return notfound()
- hosts = db.select('hosts', vars=locals(), where="uuid=$uuid")
- env = db.select('env', vars=locals(), where="uuid=$uuid")
+ hosts = db.select('hosts', vars={'uuid':uuid}, where="uuid=$uuid")
+ env = db.select('env', vars={'uuid':uuid}, where="uuid=$uuid")
return render.stats(uuid, hosts, env)
def POST(self, uuid):
diff --git a/server/post.py b/server/post.py
index b9eb46c..0aa1d98 100644
--- a/server/post.py
+++ b/server/post.py
@@ -20,6 +20,7 @@ def pkgsplit(pkgname):
return cpv
def handler(uuid, data, db):
+ #TODO: Handle exceptions
if data['PROTOCOL'] != 1:
return 'Unsupported protocol!'